From 89dc3b91bd998f9a993dc5d26b87bf7105ccd604 Mon Sep 17 00:00:00 2001
From: Matteo Boscolo <matteo.boscolo@omniasolutions.eu>
Date: Tue, 24 Sep 2024 21:11:56 +0200
Subject: [PATCH] IMP: layout and fix translation recovery with null product

---
 plm/__manifest__.py           |   2 +-
 plm/models/plm_mixin.py       |  11 ++--
 plm/models/product_product.py |   4 +-
 plm/views/product_product.xml | 113 ++++++++++++++++++----------------
 4 files changed, 68 insertions(+), 62 deletions(-)

diff --git a/plm/__manifest__.py b/plm/__manifest__.py
index 9166e817..9bd89d0c 100644
--- a/plm/__manifest__.py
+++ b/plm/__manifest__.py
@@ -20,7 +20,7 @@
 ##############################################################################
 {
     "name": "Product Lifecycle Management",
-    "version": "17.0.0.4",
+    "version": "17.0.0.5",
     "author": "OmniaSolutions",
     "website": "https://odooplm.omniasolutions.website",
     "category": "Manufacturing/Product Lifecycle Management (PLM)",
diff --git a/plm/models/plm_mixin.py b/plm/models/plm_mixin.py
index d2ed5256..9c095b71 100644
--- a/plm/models/plm_mixin.py
+++ b/plm/models/plm_mixin.py
@@ -455,11 +455,12 @@ def get_all_translation(self, object_id, fields):
         get all field translated in all available languages
         """
         out = {}
-        obj = self.env[self._name].browse([object_id])
-        for field_name in fields:
-            for code in self.env['res.lang'].search([('active','=', True)]).mapped("code"):
-                propKey = f"{field_name}@-@-@{code}"
-                out[propKey] = getattr(obj.with_context(lang=code), field_name)
+        obj = self.env[self._name].search([('id','=',object_id)])
+        if obj:
+            for field_name in fields:
+                for code in self.env['res.lang'].search([('active','=', True)]).mapped("code"):
+                    propKey = f"{field_name}@-@-@{code}"
+                    out[propKey] = getattr(obj.with_context(lang=code), field_name)
         return out
         
         
diff --git a/plm/models/product_product.py b/plm/models/product_product.py
index 8e6ab8ad..75925725 100755
--- a/plm/models/product_product.py
+++ b/plm/models/product_product.py
@@ -59,11 +59,11 @@ class ProductProduct(models.Model):
     _inherit = ['product.product']
     _description ="Product Product"
     
-    def onchange(self, values, field_name, field_onchange):
+    def onchange(self, values, field_names, fields_spec):
         values = self.plm_sanitize(values)
         if 'product_tmpl_id' in values:
             del values['product_tmpl_id']
-        return super(ProductProduct, self).onchange(values, field_name, field_onchange)
+        return super(ProductProduct, self).onchange(values, field_names, fields_spec)
 
     def action_show_reference(self):
         localCtx = self.env.context.copy()
diff --git a/plm/views/product_product.xml b/plm/views/product_product.xml
index 3eb84e38..196a057a 100755
--- a/plm/views/product_product.xml
+++ b/plm/views/product_product.xml
@@ -325,68 +325,73 @@
             <xpath expr="//notebook[last()]" position="before">
                <field name="is_engcode_editable" invisible="1"/>
                <group>
-	                <group>
-	                    <field name="engineering_code" 
-	                           readonly="is_engcode_editable==False"/>
-	                </group>
-	                <group>
-	                    <field name="engineering_revision"
-	                           readonly="is_engcode_editable==False"/>
-	                </group>
-               </group>       
-               <group>
-               		<group>
-               			<group colpsan="3" col="3">
-	                		<field name="std_description"
-	                		       colspan="4"
-	                		       readonly="engineering_state in ['released','obsoleted']"/>
-	                		<separator colspan="3" string="" invisible="1"/>
-	               			<field name="show_std_field1" invisible="1" colspan="1"/>
-	               			<field name="show_std_field2" invisible="1" colspan="1"/>
-	               			<field name="show_std_field3" invisible="1" colspan="1"/>
-	               			<field name="readonly_std_umc1" invisible="1" colspan="1"/>
-	                		<field name="readonly_std_umc2" invisible="1" colspan="1"/>
-	                		<field name="readonly_std_umc3" invisible="1" colspan="1"/>
-	                		<separator colspan="3" string="" invisible="1"/>
-	                	</group>
-	                </group>
+               <group colspan="4" col="3" string="OdooPLM Information">
+		               <field name="engineering_code"
+		                      readonly="is_engcode_editable==False"/>	              
+		               <field name="engineering_revision"
+		                      
+		                      nolabel="1"
+	                          readonly="is_engcode_editable==False"/>
+		       </group>
+		       <group colspan="4">
+	           		   <field name="std_description"
+	           		          readonly="engineering_state in ['released','obsoleted']"/>
+			   </group>
+			   <group colspan="4">
+          		<field name="show_std_field1" invisible="1"/>
+          		<field name="show_std_field2" invisible="1"/>
+          		<field name="show_std_field3" invisible="1"/>
+          		<field name="readonly_std_umc1" invisible="1"/>
+           		<field name="readonly_std_umc2" invisible="1"/>
+           		<field name="readonly_std_umc3" invisible="1"/>
+           		</group>
+
 	                
-                    <group name="std_desc_attrs"
-                           col="4"
-                           colspan="4"
-                           string="" 
-                           invisible="std_description == False">
-                        <p><b colpspan="4" size="32">Standard Description Parameters:  </b><a target="new"  href="https://www.omniasolutions.website/blog/developer-and-it-here-you-will-find-post-regarding-very-technical-aspect-of-programming-and-it-those-thinks-are-daily-used-by-omniasolutions-and-we-hope-you-that-will-help-you-3/post/standard-description-39" title="Standard description parameters info" colspan="4"><i class="fa fa-info-circle"></i></a></p>   
-                            <separator colspan="1"/>
-                            <group col="4" colspan="4">
+            <group name="std_desc_attrs"
+                   colspan="4"
+                   invisible="std_description == False">
+                <group colspan="4" col="4" string="Standard Description Parameters">
+	                <p><a target="new"  href="https://www.omniasolutions.website/blog/developer-and-it-here-you-will-find-post-regarding-very-technical-aspect-of-programming-and-it-those-thinks-are-daily-used-by-omniasolutions-and-we-hope-you-that-will-help-you-3/post/standard-description-39" title="Standard description parameters info" colspan="4"><i class="fa fa-info-circle"></i></a></p>
+	                <group colspan="1">
                             <field name="std_umc1"
                                    force_save="1"
+                                   nolabel="1"
                                    readonly="readonly_std_umc1 or engineering_state in ['released','obsoleted']"
                                    invisible="show_std_field1==False"/>
                             <field name="std_value1"
+                                   nolabel="1"
                                    readonly="std_umc1==False and engineering_state in ['released','obsoleted']"
                                    invisible="show_std_field1==False"/>
-                            <field name="std_umc2"
-                                   force_save="1"
-                                   readonly="readonly_std_umc2 or engineering_state in ['released','obsoleted']"
-                                   invisible="show_std_field2==False"/>
-                            <field name="std_value2"
-                                   readonly="std_umc2==False and engineering_state in ['released','obsoleted']"
-                                   invisible="show_std_field2==False"/>
-                            <field name="std_umc3"
-                                   force_save="1"
-                                   readonly="readonly_std_umc3 or engineering_state in ['released','obsoleted']"
-                                   invisible="show_std_field3==False"/>
-                            <field name="std_value3"
-                                   readonly="std_umc3==False and engineering_state in ['released','obsoleted']"
-                                   invisible="show_std_field3==False"/>
-                            </group>
-                    </group>
-	                <field name="source_product" invisible="1"/>
-	                <field name="desc_modify" colspan="6"
-	                       readonly="engineering_state in ['released','obsoleted']"
-	                       invisible="engineering_revision==0"/>
-               </group>
+		            </group>
+		            <group colspan="1">
+	                        <field name="std_umc2"
+	                               force_save="1"
+	                               nolabel="1"
+	                               readonly="readonly_std_umc2 or engineering_state in ['released','obsoleted']"
+	                               invisible="show_std_field2==False"/>
+	                        <field name="std_value2"
+	                               nolabel="1"
+	                               readonly="std_umc2==False and engineering_state in ['released','obsoleted']"
+	                               invisible="show_std_field2==False"/>
+		           </group>
+		           <group colspan="1">
+	                        <field name="std_umc3"
+	                               force_save="1"
+	                               nolabel="1"
+	                               readonly="readonly_std_umc3 or engineering_state in ['released','obsoleted']"
+	                               invisible="show_std_field3==False"/>
+	                        <field name="std_value3"
+	                               nolabel="1"
+	                               readonly="std_umc3==False and engineering_state in ['released','obsoleted']"
+	                               invisible="show_std_field3==False"/>
+	                </group>
+                  </group>  
+                </group>
+	            <field name="source_product" invisible="1"/>
+                <field name="desc_modify" colspan="6"
+	                   readonly="engineering_state in ['released','obsoleted']"
+	                   invisible="engineering_revision==0"/>
+            </group>    
             </xpath>
             <xpath expr="//notebook[last()]" position="inside">
 				<page name="technical_infos" string="Technical Information">