Merge pull request #2202 from OmniSharp/feature/log-external-features…

…-warning log a warning when external features path has no assemblies
OmniSharp · Jul 31, 2021 · e55adb0 · e55adb0
2 parents 9c293cb + 56e0769
commit e55adb0
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/OmniSharp.Roslyn.CSharp/Services/ExternalFeaturesHostServicesProvider.cs b/src/OmniSharp.Roslyn.CSharp/Services/ExternalFeaturesHostServicesProvider.cs
@@ -2,6 +2,7 @@
 using System.Composition;
 using System.Linq;
 using System.Reflection;
+using Microsoft.Extensions.Logging;
 using OmniSharp.Options;
 using OmniSharp.Services;
 
@@ -15,16 +16,25 @@ public class ExternalFeaturesHostServicesProvider : IHostServicesProvider
         public ImmutableArray<Assembly> Assemblies { get; }
 
         [ImportingConstructor]
-        public ExternalFeaturesHostServicesProvider(IAssemblyLoader loader, OmniSharpOptions options, IOmniSharpEnvironment environment)
+        public ExternalFeaturesHostServicesProvider(IAssemblyLoader loader, OmniSharpOptions options, IOmniSharpEnvironment environment, ILoggerFactory loggerFactory)
         {
             var builder = ImmutableArray.CreateBuilder<Assembly>();
 
             var roslynExtensionsLocations = options.RoslynExtensionsOptions.GetNormalizedLocationPaths(environment);
             if (roslynExtensionsLocations?.Any() == true)
             {
+                var logger = loggerFactory.CreateLogger<ExternalFeaturesHostServicesProvider>();
                 foreach (var roslynExtensionsLocation in roslynExtensionsLocations)
                 {
-                    builder.AddRange(loader.LoadAllFrom(roslynExtensionsLocation));
+                    var loadedAssemblies = loader.LoadAllFrom(roslynExtensionsLocation);
+                    if (loadedAssemblies.Any())
+                    {
+                        builder.AddRange(loadedAssemblies);
+                    }
+                    else
+                    {
+                        logger.LogWarning($"The path '{roslynExtensionsLocation}' is configured in the RoslynExtensionsOptions as the external features source but no assemblies were found at this path.");
+                    }
                 }
             }