-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to typescript #85
Comments
👍 I suspect that transpiler might be more trouble than it's worth, and it would be easier to compile to JS and then TypeScriptify it. But it couldn't hurt to try it first. https://github.com/borisyankov/DefinitelyTyped/blob/master/atom/atom.d.ts |
So what's the action plan? Create a new branch for the TypeScript version? What needs to be done, and what can the rest of us do to help? Based on observation of the earlier #omnisharp conversations, the move to TS would potentially mean more contributors to this package. It seems unfamiliarity towards coffeescript was/is a factor for some. |
@willl asked me to voice my opinion so here it is: Considering the number of files (under 50) I would be tempted to just rewrite files by hand on by one. I've been doing that when porting over other peoples coffeescript stuff to typescript. Consider: I would just rename to
For views I would leave the ones that are okay in Coffee e.g. : https://github.com/OmniSharp/omnisharp-atom/blob/master/lib/omnisharp-atom/views/omni-output-pane-view.coffee You can even leave the The thing that will absolutely drive you up the wall is heavy use of Later when you have more stuff in 🌹 |
I'm completely green with typescript as well, but I'd support this migration! 👍 |
I'd be willing to help as well. |
@willl, @david-driscoll and @ctolkien have offered to migrate this over. Why don't we make them contributors so they can collaborate more easily? |
Please do not make me a contributor |
@will - oops, fixed :) |
:) |
I suggested on JabbR that we make a list similar to this one (OmniSharp/omnisharp-roslyn#29) with each file listed. Then when someone wants to work on that file, they can just put their name next to it. |
Also don't use initialize : https://github.com/TypeStrong/atom-typescript/blob/master/docs/spacepen.md |
It's happening #98. :) |
Current code in master is now in TypeScript now that 0.3.0 has been released. Contributions always welcome :) |
Since we pushed 0.4.0 as typescript, I think we can close this! 🎉 |
Atom will/already does support
.ts
files OOTB now!atom/atom#5898
we could try https://www.npmjs.com/package/coffee-script-to-typescript to do the conversion automatically.
I personally like coffeescript/typescript equally but the overwhelming consensus in #omnisharp on jabbr is in favor of TS so lets move this sucker over 😄
The text was updated successfully, but these errors were encountered: