Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin manager states update is available but it will not install #2

Closed
joeySeal opened this issue Nov 4, 2019 · 9 comments
Closed
Labels
type: bug Something isn't working

Comments

@joeySeal
Copy link

joeySeal commented Nov 4, 2019

Octprint update manager will not update to rc2

2019-11-03 19:33:02,261 - octoprint.plugins.softwareupdate - INFO - Starting update of PrintJobHistory to 1.0.0-rc2... 2019-11-03 19:33:39,160 - octoprint.plugins.softwareupdate - INFO - Update of PrintJobHistory to 1.0.0-rc2 successful! 2019-11-03 19:33:39,345 - octoprint.plugins.softwareupdate - INFO - Saved version cache to disk 2019-11-03 19:33:39,348 - octoprint.plugins.softwareupdate - INFO - Restarting... 2019-11-03 19:33:39,538 - octoprint.server - INFO - Shutting down... 2019-11-03 19:33:39,682 - octoprint.events - INFO - Processing shutdown event, this will be our
print_history

@OllisGit
Copy link
Owner

OllisGit commented Nov 4, 2019

Hi @joeySeal ,

did you already try:

  • uninstall RC1
  • reboot system
  • install RC2

If this also not working, please attach the full octoprint.log file.

@OllisGit OllisGit added status: waitingForFeedback Wating for Customers feedback type: bug Something isn't working labels Nov 4, 2019
@joeySeal
Copy link
Author

joeySeal commented Nov 4, 2019

@OllisGit how should I be installing? Via URL? (https://github.com/OllisGit/OctoPrint-PrintJobHistory/releases/latest/download/master.zip) or from the plugin manager. It does not appear in the plugin repo search.

@Putzi76
Copy link

Putzi76 commented Nov 4, 2019

Hi @joeySeal ,

did you already try:

  • uninstall RC1
  • reboot system
  • install RC2

If this also not working, please attach the full octoprint.log file.

it works for me.
Thanks

@OllisGit
Copy link
Owner

OllisGit commented Nov 4, 2019

@kwatcharasupat
Copy link

@OllisGit I just looked at setup.py of rc2 and it seems that the plugin version is not updated

# The plugin's version. Can be overwritten within OctoPrint's internal data via __plugin_version__ in the plugin module
plugin_version = "1.0.0rc1.1"

@OllisGit
Copy link
Owner

OllisGit commented Nov 7, 2019

Hi @joeySeal ,
Damm, I forgot to push the setup file with the new version-number.

@karnwatcharasupat: thx, for analysing!

If you did a clean installation, you should receive rc2 (only with wrong version number), but updating from rc1.1 to rc2 could not work.

I will improve my build/releasmanagement, so that the setup version-number is the same as the git release-number.

Now rc2.1 is out, please test and give feedback.

Thx, Olli

@b-morgan
Copy link

b-morgan commented Nov 7, 2019

I have rc2.1 installed but I still get an update available message, see attached.
PrintHistory
If there is something else you need from me, let me know.

@b-morgan
Copy link

b-morgan commented Nov 7, 2019

I notice from the above screenshot that the name of the plugin in the manager is "Job History" but the project is PrintJobHistory. Should the two be more similar?

@OllisGit
Copy link
Owner

OllisGit commented Nov 7, 2019

Hi @b-morgan ,
thanks a lot for pointing it out to me.

  1. You installed the current version "rc2.1" and in the right popup the previous plugin "rc2" is mentioned. I think Octoprint has some "challenges" to identify the right number, so I removed the old "rc2" from my github release-panel. That should solve the issue.
  2. I am not really "lucky" with the name "PrintJobHistory", so the idea was to shorten that Name and reuse the internal PluginId, but that is confusing. I will change that in the next version.

Again, thanks for your testing support!
Olli

@OllisGit OllisGit removed the status: waitingForFeedback Wating for Customers feedback label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants