Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing Request.credentials from same-origin to include #38

Closed
jcbpl opened this issue Jul 13, 2018 · 2 comments
Closed

Consider changing Request.credentials from same-origin to include #38

jcbpl opened this issue Jul 13, 2018 · 2 comments

Comments

@jcbpl
Copy link
Contributor

jcbpl commented Jul 13, 2018

I'm interested in deploying graphiql-workspace so that it could be used to call multiple authenticated graphql endpoints that run on subdomains of my company's TLD. Currently, the implementation of fallbackFetcher precludes this because it calls fetch with credentials: 'same-origin' instead of credentials: 'include':

credentials: 'same-origin',

Would there be any objection to changing same-origin to include? (FWIW, that's what the reference example in the graphiql repo does.)

Alternatively, if the use of same-origin is deliberate, would it be possible to make it a configuration option?

Thanks!

@OlegIlyenko
Copy link
Owner

OlegIlyenko commented Jul 17, 2018

I'm not an expert on CORS, but I think include has it's own set of issues: #27 (the original PR that chnaged it to same-origin).

I don't mind parametrizing it though. Would you like to make a PR?

@jcbpl
Copy link
Contributor Author

jcbpl commented Jul 18, 2018

Ah, got it. Yep, I'll open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants