Revert "Update adapter json test framework to validate BidVideo (preb…

…id#3835)" This reverts commit 6fd8d18.
Ogury · Oct 30, 2024 · a91bf3c · a91bf3c
1 parent b74653b
commit a91bf3c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 22 deletions.
diff --git a/adapters/adapterstest/test_json.go b/adapters/adapterstest/test_json.go
@@ -226,10 +226,9 @@ type expectedBidResponse struct {
 }
 
 type expectedBid struct {
-	Bid   json.RawMessage `json:"bid"`
-	Type  string          `json:"type"`
-	Seat  string          `json:"seat"`
-	Video json.RawMessage `json:"video,omitempty"`
+	Bid  json.RawMessage `json:"bid"`
+	Type string          `json:"type"`
+	Seat string          `json:"seat"`
 }
 
 // ---------------------------------------
@@ -343,9 +342,6 @@ func diffBids(t *testing.T, description string, actual *adapters.TypedBid, expec
 	assert.Equal(t, string(expected.Seat), string(actual.Seat), fmt.Sprintf(`%s.seat "%s" does not match expected "%s."`, description, string(actual.Seat), string(expected.Seat)))
 	assert.Equal(t, string(expected.Type), string(actual.BidType), fmt.Sprintf(`%s.type "%s" does not match expected "%s."`, description, string(actual.BidType), string(expected.Type)))
 	assert.NoError(t, diffOrtbBids(fmt.Sprintf("%s.bid", description), actual.Bid, expected.Bid))
-	if expected.Video != nil {
-		assert.NoError(t, diffBidVideo(fmt.Sprintf("%s.video", description), actual.BidVideo, expected.Video))
-	}
 }
 
 // diffOrtbBids compares the actual Bid made by the adapter to the expectation from the JSON file.
@@ -362,15 +358,6 @@ func diffOrtbBids(description string, actual *openrtb2.Bid, expected json.RawMes
 	return diffJson(description, actualJson, expected)
 }
 
-func diffBidVideo(description string, actual *openrtb_ext.ExtBidPrebidVideo, expected json.RawMessage) error {
-	actualJson, err := json.Marshal(actual)
-	if err != nil {
-		return fmt.Errorf("%s failed to marshal actual Bid Video into JSON. %v", description, err)
-	}
-
-	return diffJson(description, actualJson, []byte(expected))
-}
-
 // diffJson compares two JSON byte arrays for structural equality. It will produce an error if either
 // byte array is not actually JSON.
 func diffJson(description string, actual []byte, expected []byte) error {

diff --git a/adapters/freewheelssp/freewheelssptest/exemplary/multi-imp.json b/adapters/freewheelssp/freewheelssptest/exemplary/multi-imp.json
@@ -153,8 +153,7 @@
           },
           "type": "video",
           "video" : {
-            "duration" : 10,
-            "primary_category": ""
+            "duration" : 10
           }
         }
       ]

diff --git a/adapters/pubmatic/pubmatictest/exemplary/video.json b/adapters/pubmatic/pubmatictest/exemplary/video.json
@@ -177,8 +177,7 @@
             },
             "type": "video",
             "video" :{
-              "duration" : 5,
-              "primary_category": ""
+              "duration" : 5
             }
           }
         ]

diff --git a/adapters/yeahmobi/yeahmobitest/exemplary/simple-video.json b/adapters/yeahmobi/yeahmobitest/exemplary/simple-video.json
@@ -96,8 +96,7 @@
           },
           "type": "video",
           "video": {
-            "duration": 300,
-            "primary_category": ""
+            "duration": 300
           }
         }
       ]