Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support node 20 - upgrade msal-node module #10849

Open
omeralon1 opened this issue Feb 6, 2024 · 6 comments
Open

Feature request: Support node 20 - upgrade msal-node module #10849

omeralon1 opened this issue Feb 6, 2024 · 6 comments
Assignees
Labels
feature-request The issue is a feature request TA:E2E Team Area: E2E
Milestone

Comments

@omeralon1
Copy link

omeralon1 commented Feb 6, 2024

Request Details
Trying to install teamsfx package on node 20 project with yarn, but the installation can't be done due to old deprecated version of msal-node package requirement (1.18.4)
This version supports node version 18 and below.
The error I get when trying to install:
@azure/[email protected]: The engine "node" is incompatible with this module. Expected version "10 || 12 || 14 || 16 || 18". Got "20.9.0"
After this message yarn fails the installation.

Solution Description
Upgrade msal-node module to version 2+, which supports node 20.

Alternatives Considered

  • Downgrade the whole project node version to 18
  • Install using --ignore-engines flag
  • Install using npm instead of yarn, which only warns but doesn't fail the installation

Will appreciate your help!

@eitanlevinzon-astrix
Copy link

+1

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Feb 6, 2024
@adashen adashen added investigating TA:Infra Team Area: Infra labels Feb 7, 2024
@MuyangAmigo
Copy link
Collaborator

Hey @omeralon1, @eitanlevinzon-astrix we are working on an upgrade of teamsfx to use the latest msal-node packages, please stay tunned.

@MuyangAmigo MuyangAmigo added TA:E2E Team Area: E2E and removed needs attention This issue needs the attention of a contributor. TA:Infra Team Area: Infra labels Feb 8, 2024
@yiqing-zhao
Copy link
Contributor

Hi @omeralon1, @eitanlevinzon-astrix, all Teams bots and message extensions are developed using the botbuilder-js SDK. Presently, we're eagerly anticipating support for Node.js 20 in the Botbuilder SDK. You can track the progress of this issue at microsoft/botbuilder-js#4550.

We've conducted tests to ensure that our current templates remain functional after upgrading to Node.js 20. As a temporary workaround for any warnings encountered, you can use "npm install --ignore-engines". We'll keep you informed and update here once we receive any feedback from the botbuilder team. Thanks!

@omeralon1
Copy link
Author

omeralon1 commented Feb 18, 2024

Hi @yiqing-zhao
Thank you for the answer 😄
Will keep tracking 👀

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Feb 18, 2024
@adashen adashen added feature-request The issue is a feature request and removed investigating needs attention This issue needs the attention of a contributor. labels Feb 19, 2024
@adashen adashen added this to the Backlog milestone Feb 19, 2024
@Kamahl19
Copy link

Kamahl19 commented Sep 9, 2024

@yiqing-zhao @MuyangAmigo The botbuilder has updated msal to @azure/msal-node in their latest releast however the @microsoft/teamsfx still references the "@azure/msal-node": "^1.14.6", which is causing installation warning.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Sep 9, 2024
@yiqing-zhao
Copy link
Contributor

@yiqing-zhao @MuyangAmigo The botbuilder has updated msal to @azure/msal-node in their latest releast however the @microsoft/teamsfx still references the "@azure/msal-node": "^1.14.6", which is causing installation warning.

Hi @Kamahl19, we're currently working on upgrading TeamsFx SDK, and will update here once it’s merged and released. Thanks!

@adashen adashen removed the needs attention This issue needs the attention of a contributor. label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request The issue is a feature request TA:E2E Team Area: E2E
Projects
None yet
Development

No branches or pull requests

7 participants