Fix app crash when we focus on charts in IE (#14946)

* Fix issue when we focus on charts in IE * Change files Co-authored-by: Rajesh Goriga <[email protected]>
microsoft · Sep 9, 2020 · d0bdb5b · d0bdb5b
1 parent 311ed1e
commit d0bdb5b
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/change/@uifabric-charting-2020-09-09-11-17-25-user-gorraj-bug_4377550.json b/change/@uifabric-charting-2020-09-09-11-17-25-user-gorraj-bug_4377550.json
@@ -0,0 +1,8 @@
+{
+  "type": "patch",
+  "comment": "Fix issue when we focus on charts in IE",
+  "packageName": "@uifabric/charting",
+  "email": "[email protected]",
+  "dependentChangeType": "patch",
+  "date": "2020-09-09T05:47:25.235Z"
+}
diff --git a/packages/charting/src/components/GroupedVerticalBarChart/GroupedVerticalBarChart.base.tsx b/packages/charting/src/components/GroupedVerticalBarChart/GroupedVerticalBarChart.base.tsx
@@ -388,7 +388,6 @@ export class GroupedVerticalBarChartBase extends React.Component<
         .enter()
         .append('rect')
         .style('fill', (d: IGVSingleDataPoint) => d[datasetKey].color)
-        .attr('focusable', true)
         .attr('data-is-focusable', true)
         .attr('class', this._classNames.opacityChangeOnHover)
         .attr('fill-opacity', (d: IGVForBarChart) => that._getOpacity(d[datasetKey].legend))

diff --git a/packages/charting/src/components/StackedBarChart/MultiStackedBarChart.base.tsx b/packages/charting/src/components/StackedBarChart/MultiStackedBarChart.base.tsx
@@ -154,7 +154,6 @@ export class MultiStackedBarChartBase extends React.Component<IMultiStackedBarCh
             this._refCallback(e, point.legend!);
           }}
           data-is-focusable={true}
-          focusable={'true'}
           onFocus={this._onBarFocus.bind(
             this,
             point.legend!,

diff --git a/packages/charting/src/components/StackedBarChart/StackedBarChart.base.tsx b/packages/charting/src/components/StackedBarChart/StackedBarChart.base.tsx
@@ -264,7 +264,6 @@ export class StackedBarChartBase extends React.Component<IStackedBarChartProps,
             this._refCallback(e, legend.title);
           }}
           data-is-focusable={true}
-          focusable={'true'}
           onFocus={this._onBarFocus.bind(
             this,
             point.legend!,

diff --git a/packages/charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx b/packages/charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx
@@ -463,7 +463,6 @@ export class VerticalStackedBarChartBase extends React.Component<
             this._refCallback(e, point.legend, refArrayIndexNumber);
           }}
           data-is-focusable={true}
-          focusable={'true'}
           onMouseOver={this._onBarHover.bind(
             this,
             point.legend,