Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to doc for return types #433

Closed
jakobpn opened this issue Jun 17, 2019 — with docs.microsoft.com · 6 comments
Closed

Link to doc for return types #433

jakobpn opened this issue Jun 17, 2019 — with docs.microsoft.com · 6 comments
Assignees
@AlexJerabek
Labels
Area: add-ins Feedback on add-ins content that's relevant to multiple Office hosts. Resolution: external Issue isn't related to the Office Add-ins platform, Office JavaScript APIs, or documentation Status: fixed Fix is complete and will be available to customers as soon as doc updates are published Type: doc request Request for new documentation or updates/enhancements to existing documentation

Comments

@jakobpn docs.microsoft.com
Copy link
Member

jakobpn commented Jun 17, 2019

Hi there, it would be awesome if this page had links to the documentation for the return types such as the Excel.WorksheetSingleClickedEventArgs type.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@AlexJerabek
Copy link
Contributor

AlexJerabek commented Jun 17, 2019 •
edited
Loading

Hi @jakobpn,
The lack of links in genericized types is a known issue with our tooling chain. In the meantime, I can help compensate by writing some sample code to showcase the return type's properties.

@AlexJerabek AlexJerabek self-assigned this Jun 17, 2019
@jakobpn
Copy link
Member Author

jakobpn commented Jun 17, 2019

Glad to hear that it being tracked. I can find the return type in the table of contents on the left of the page, but a link to the doc would speed things up.

@AlexJerabek
Copy link
Contributor

@jakobpn As an update, this web-build-tools PR will fix the linking issue. They still need to go through testing and approval, but I have verified the complex type linking will be fixed.

@wamaina
Copy link
Member

wamaina commented Aug 6, 2019

@AlexJerabek, are there any updates on this?

@AlexJerabek
Copy link
Contributor

@wamaina This is still blocked on microsoft/rushstack#1337.

@AlexJerabek AlexJerabek added Resolution: external Issue isn't related to the Office Add-ins platform, Office JavaScript APIs, or documentation enhancement Status: under investigation Issue is being investigated labels Aug 6, 2019
@kbrandl kbrandl added Type: doc request Request for new documentation or updates/enhancements to existing documentation and removed enhancement labels Aug 12, 2019
@kbrandl kbrandl added the Area: add-ins Feedback on add-ins content that's relevant to multiple Office hosts. label Aug 26, 2019
@AlexJerabek AlexJerabek added Status: fixed Fix is complete and will be available to customers as soon as doc updates are published and removed Status: under investigation Issue is being investigated labels Sep 11, 2019
@AlexJerabek
Copy link
Contributor

@jaokbpn This should be fixed by #510. Those changes will make it to the live site soon. I'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexJerabek AlexJerabek

Labels
Area: add-ins Feedback on add-ins content that's relevant to multiple Office hosts. Resolution: external Issue isn't related to the Office Add-ins platform, Office JavaScript APIs, or documentation Status: fixed Fix is complete and will be available to customers as soon as doc updates are published Type: doc request Request for new documentation or updates/enhancements to existing documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kbrandl @jakobpn @wamaina @AlexJerabek