Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

office-addin-dev-certs: keeps adding new certs on mac #233

Closed
gordonmleigh opened this issue Nov 20, 2019 · 1 comment
Closed

office-addin-dev-certs: keeps adding new certs on mac #233

gordonmleigh opened this issue Nov 20, 2019 · 1 comment
Assignees
Labels
bug Something isn't working triaged Bug has been triaged

Comments

@gordonmleigh
Copy link

When the certificate has less than a day until expiry, the certificate verification step fails, and it adds a new certificate. The next time it tries to verify the certificate, it still sees the old certificate, and creates another new certificate.

This is how you are verifying certificates:

case "darwin": // macOS
return `security find-certificate -c '${defaults.certificateName}' -p | openssl x509 -checkend 86400 -noout`;

The security find-certificate call finds the first matching certificate, which is the expiring one, even after a new certificate is added.

@LouMM LouMM added bug Something isn't working triaged Bug has been triaged labels Jul 23, 2020
@LouMM LouMM linked a pull request Jul 23, 2020 that will close this issue
@millerds millerds self-assigned this Nov 9, 2021
@millerds
Copy link
Contributor

millerds commented Jun 9, 2022

I have checked in some updates to scripts that manage the certs. They should be better about deleting expired and duplicate certs and looking for a valid one.

@millerds millerds closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Bug has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants