Use the new go client for scheduled trigger to allow scoping by space ID #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SC-97304]
This PR partially fixes #740
We previously only used the space ID of the client when reading the scheduled project trigger resource from Octopus. When these IDs were not the same, the resource could not be found. By using the new version of the go client, we can search by the space ID on the resource when known.
This PR resolves issues found when creating/updating resources on Octopus, but does not resolve the issue with terraform import. Terraform import does not provide us with a resource containing a Space ID, so a larger refactor will be required to resolve this issue.