All committers have signed the CLA.

I think for some of those methods that take parameterized array such as:
https://github.com/OctopusDeploy/OctopusClients/pull/549/files#diff-b4563a4a2fe786ba2dd3fa2ccdaef341R19

we can probably leave the old definition as is i.e.:
Task<List<TAccount>> GetOfType<TAccount>(params string[] ids)

and add another one that takes the token (not optional but required) Task<List> GetOfType(CancellationToken token, params string[] ids)`

while remove this signature that I modified it to earlier:
Task<List<TAccount>> GetOfType<TAccount>(CancellationToken token = default, params string[] ids)

This way it doesn't break other codebases. Although its best practice to take token as the last default parameter but not sure how best to get away with this.

@matt-richardson any thoughts on above? and when can this be merged and available for usage once ready. Appreciate any feedback!

@matt-richardson any thoughts on above? and when can this be merged and available for usage once ready. Appreciate any feedback!

Hi @yj7o5 - thanks for the PR. I've passed it onto the right team here to look at. Hopefully they should get to it soon.

As for the param ordering, we could either put the cancellation token first, or add an overload that drops the params part, so it takes an array and a token. Right now I'm not entirely sure... 🤔 Do what you think best and the team will look at it in more detail soon.

Unfortunately the QRF team did not have capacity to address this PR. We'll keep the PR open, but unfortunately we can not provide any guidance as to when it will be resolved.

That's fine. Appreciate the response.