Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compat] Don't generate error for non-data ExecuteReader queries #75

Open
MaceWindu opened this issue Apr 2, 2023 · 1 comment
Open
Assignees

Comments

@MaceWindu
Copy link
Contributor

MaceWindu commented Apr 2, 2023

Currently it generates There is no table in the server's response. error (e.g. for DML query like CREATE TABLE), which doesn't match behavior of other ADO.NET providers where they return empty data reader.

Real world example:

This behavior is not compatible with LINQPad raw SQL functionality as it use ExecuteReader API internally for all raw SQL queries:

  • LINQPad shows error
  • LINQPad treats exception as query failure (which is not true, as server executed query successfully) and doesn't apply success branch post-query logic (e.g. doesn't check that database schema changed and should be reloaded)
@MaceWindu
Copy link
Contributor Author

BTW, this should useful for compat testing dotnet/runtime#17004 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants