Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneratedHydrator Mixes up private properties #51

Open
staabm opened this issue Apr 28, 2016 · 2 comments
Open

GeneratedHydrator Mixes up private properties #51

staabm opened this issue Apr 28, 2016 · 2 comments
Labels

Comments

@staabm
Copy link
Contributor

staabm commented Apr 28, 2016

As of current implementation, GeneratedHydrator will not distinguish between properties from following
example:

class Foo
{
    private $bar;
}

class Bar extends Foo
{
    private $bar;
}

class Baz extends Foo
{
    private $bar;
}
@pounard
Copy link
Contributor

pounard commented Jan 11, 2017

This is potentially fixed with PR #59 - it orders the private properties in hierarchy order (from the top level parent to lowest child) and set only the children private properties when they are private properties that hide the parent one.

@pounard
Copy link
Contributor

pounard commented Jan 11, 2017

Actually, it's not fixed, it's just more predictable. In order to fix this #5 must be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants