tbls: cleanup to remove verifiers #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 56.39% 56.40% +0.01%
==========================================
Files 96 96
Lines 9106 9105 -1
==========================================
+ Hits 5135 5136 +1
+ Misses 3234 3232 -2
Partials 737 737
Continue to review full report at Codecov.
|
xenowits
approved these changes
May 25, 2022
docs/configuration.md
Outdated
| @@ -51,7 +51,7 @@ The `cluster-lock.json` has the following schema: | |||
| "distributed_validators": [ // Length equaled to num_validators. | |||
| { | |||
| "distributed_public_key": "0x123..abfc", // DV root pubkey | |||
| "threshold_verifiers": [ "oA8Z...2XyT", "g1q...icu"], // length of threshold | |||
| "public_shares": [ "oA8Z...2XyT", "g1q...icu"], // length of threshold | |||
There was a problem hiding this comment.
not length of threshold anymore, instead equal to length of num_operators
There was a problem hiding this comment.
Also, fix comment on line 51: // Length equal to num_validators
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining cleanup to replace verifiers with public shares based on the comments on #604
category: refactor
ticket: none