Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bumped protoc-gen-go #3331

Merged
merged 1 commit into from
Oct 10, 2024
Merged

*: bumped protoc-gen-go #3331

merged 1 commit into from
Oct 10, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Oct 10, 2024

The new protoc-gen-go v1.35.1 needs our proto files to be regenerarted, otherwise pre-commit is failing.

category: fixbuild
ticket: none

@pinebit pinebit marked this pull request as ready for review October 10, 2024 07:36
Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 65.85366% with 56 lines in your changes missing coverage. Please review.

Project coverage is 58.81%. Comparing base (8eb99c8) to head (300f48d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
dkg/dkgpb/v1/frost.pb.go 50.00% 12 Missing and 2 partials ⚠️
cluster/manifestpb/v1/manifest.pb.go 63.88% 13 Missing ⚠️
core/corepb/v1/priority.pb.go 35.00% 13 Missing ⚠️
core/corepb/v1/consensus.pb.go 55.00% 9 Missing ⚠️
app/log/loki/lokipb/v1/loki.pb.go 41.66% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3331      +/-   ##
==========================================
+ Coverage   57.95%   58.81%   +0.86%     
==========================================
  Files         210      210              
  Lines       30616    30213     -403     
==========================================
+ Hits        17742    17770      +28     
+ Misses      10978    10552     -426     
+ Partials     1896     1891       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 10, 2024
@obol-bulldozer obol-bulldozer bot merged commit 6f9863c into main Oct 10, 2024
13 of 14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/bumped-protoc branch October 10, 2024 07:51
pinebit added a commit that referenced this pull request Oct 18, 2024
The new protoc-gen-go v1.35.1 needs our proto files to be regenerarted, otherwise pre-commit is failing.

category: fixbuild
ticket: none
KaloyanTanev pushed a commit that referenced this pull request Nov 20, 2024
The new protoc-gen-go v1.35.1 needs our proto files to be regenerarted, otherwise pre-commit is failing.

category: fixbuild
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants