*: release v1.1.1 #3287
Merged
*: release v1.1.1 #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the "gnosis_block_hotfix" feature flag is enabled, use the Gnosis-compatible representation of the proposal when calculating its hash tree root. This should fix Gnosis proposals failing due to bad signature. category: feature ticket: #3181 feature_flag: gnosis_block_hotfix
* Added `chiado` network spec in addition to the existing `gnosis`. * Feature `gnosis_block_hotfix` is enabled automatically when gnosis | chiado network is detected. * When the user explicitly disables `gnosis_block_hotfix` feature, the app just yields warning during startup: ``` Feature gnosis_block_hotfix is required by gnosis/chiado, but explicitly disabled ``` category: feature ticket: none feature_flag: gnosis_block_hotfix
- fix test peers on timeout, sometimes it went in the case where the current context is done, but the result of the currently running test wasn't sent to the channel - fix wrongly named variables category: test ticket: none
Fixing flaky test in previous PR #3267 revealed another issue. Fixing that one, which is purely unit test related. category: test ticket: none
After #3267 was merged, on `ctx.Done()` we push the latest unfinished test. This causes out of range in the outer function in some ocassions. category: bug ticket: none
github-actions
bot
added
the
branch-release
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-v1.1 #3287 +/- ##
=============================================
- Coverage 57.73% 57.67% -0.07%
=============================================
Files 211 211
Lines 30369 30398 +29
=============================================
- Hits 17535 17532 -3
- Misses 10950 10980 +30
- Partials 1884 1886 +2 ☔ View full report in Codecov by Sentry. |
KaloyanTanev
approved these changes
Sep 16, 2024
gsora
approved these changes
Sep 16, 2024
Compose tests were failing because of `docker-compose` command hasn't been changed to `docker compose` on some places and the version on top wasn't removed. category: test ticket: none
|
|
Added #3249 to avoid compose tests failure. |
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release v1.1.1 cherry picked:
*: fix flaky testpeers test #3267
category: misc
ticket: none