Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil: update docker-compose command to docker compose #3249

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

KaloyanTanev
Copy link
Contributor

@KaloyanTanev KaloyanTanev commented Sep 3, 2024

Compose tests were failing because of docker-compose command hasn't been changed to docker compose on some places and the version on top wasn't removed.

category: test
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.66%. Comparing base (6a5448f) to head (2ded7cc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3249   +/-   ##
=======================================
  Coverage   57.65%   57.66%           
=======================================
  Files         211      211           
  Lines       30375    30375           
=======================================
+ Hits        17513    17515    +2     
+ Misses      10976    10973    -3     
- Partials     1886     1887    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev force-pushed the kalo/update-docker-compose-in-tests branch from eff5dc6 to 2ded7cc Compare September 4, 2024 00:04
Copy link

sonarcloud bot commented Sep 4, 2024

@pinebit
Copy link
Contributor

pinebit commented Sep 4, 2024

Finally this fixes our CI. Good job!

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 4, 2024
@obol-bulldozer obol-bulldozer bot merged commit 0fd3af2 into main Sep 4, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/update-docker-compose-in-tests branch September 4, 2024 07:49
pinebit pushed a commit that referenced this pull request Sep 17, 2024
Compose tests were failing because of `docker-compose` command hasn't been changed to `docker compose` on some places and the version on top wasn't removed.

category: test
ticket: none
@pinebit pinebit mentioned this pull request Sep 17, 2024
obol-bulldozer bot pushed a commit that referenced this pull request Sep 17, 2024
For release v1.1.1 cherry picked:

* [core/validatorapi: workaround for Gnosis proposals](#3238)
* [*: enable gnosis hotfix automatically](#3257)
*: [fix flaky testpeers test #3267](#3267)
* [cmd: increase testpeers tests timeouts #3268](#3268)
* [cmd: fix test peers out of range #3280](#3280)
* [testutil: update docker-compose command to docker compose](#3249)

category: misc
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants