core: deprecate VersionedSignedBlindedProposal #3155
Conversation
Convert VersionedSignedProposals to their blinded counterpart (requested by go-eth2-client & Beacon API spec) on-demand, so that the execution flow is simpler to understand and debug.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
==========================================
- Coverage 56.89% 56.72% -0.18%
==========================================
Files 208 208
Lines 29365 29202 -163
==========================================
- Hits 16707 16564 -143
+ Misses 10817 10811 -6
+ Partials 1841 1827 -14 ☔ View full report in Codecov by Sentry. |
|
| @@ -0,0 +1,350 @@ | |||
| { | |||
There was a problem hiding this comment.
If we add this, do we still need to keep the golden blinded equivalent? Also, probably it would be nice to include "blinded": false in the non-#01 version.
There was a problem hiding this comment.
hmm well there's no value so it'll be false by default
keep the golden blinded equivalent
you mean the golden files for VersionedSignedBlindedProposal?
gsora
added
the
merge when ready
obol-bulldozer
bot
deleted the
gsora/deprecate-versionedsignedblindedproposal
branch
Convert `VersionedSignedProposals` to their blinded counterpart (requested by go-eth2-client & Beacon API spec) on-demand, so that the execution flow is simpler to understand and debug. category: refactor ticket: none
Convert
VersionedSignedProposalsto their blinded counterpart (requested by go-eth2-client & Beacon API spec) on-demand, so that the execution flow is simpler to understand and debug.category: refactor
ticket: none