core/bcast: broadcast either blinded or full block #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shortcut `/eth/v2/beacon/blinded_blocks/submit_blinded_block_v2` to use newer proposals rather than blinded block proposals.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3144 +/- ##
==========================================
- Coverage 56.83% 56.80% -0.04%
==========================================
Files 208 208
Lines 29314 29336 +22
==========================================
+ Hits 16662 16665 +3
- Misses 10811 10828 +17
- Partials 1841 1843 +2 ☔ View full report in Codecov by Sentry. |
|
KaloyanTanev
approved these changes
Jun 21, 2024
gsora
added
the
merge when ready
gsora
changed the title
pinebit
reviewed
Jun 24, 2024
| ok bool | ||
| ) | ||
|
|
||
| block, ok = aggData.(core.VersionedSignedProposal) |
There was a problem hiding this comment.
It's terrible that we have to do all these castings.. and sad that I overlooked this issue in bcast.
gsora
added a commit
that referenced
this pull request
Jun 25, 2024
Shortcut `/eth/v2/beacon/blinded_blocks/submit_blinded_block_v2` to use newer proposals rather than blinded block proposals. category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check what type of proposal we're broadcasting before calling
SubmitProposal.category: bug
ticket: none