cmd: increase timeout of timeout test #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaloyanTanev
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3079 +/- ##
==========================================
- Coverage 56.49% 56.42% -0.07%
==========================================
Files 208 208
Lines 29020 29018 -2
==========================================
- Hits 16395 16374 -21
- Misses 10805 10823 +18
- Partials 1820 1821 +1 ☔ View full report in Codecov by Sentry. |
pinebit
reviewed
May 8, 2024
cmd/testbeacon_internal_test.go
Outdated
| @@ -96,7 +96,7 @@ func TestBeaconTest(t *testing.T) { | |||
| OutputToml: "", | |||
| Quiet: false, | |||
| TestCases: nil, | |||
| Timeout: time.Nanosecond, | |||
| Timeout: 5 * time.Nanosecond, | |||
There was a problem hiding this comment.
It's your business but to me this is the first indicator of potentially flakey test. :)
There was a problem hiding this comment.
Looks a bit weird indeed, but I want to have some timeout that is triggered before my HTTP call succeeds... Currently this test will falsely fail on 2 occasions:
- If the http call is blazing fast (<100ns), but that is impossible I believe
- If the code executes slower in some go routines and it doesn't reach the step of registering all the targets it needs to call (what happened before). I've bumped it to 100ns now. Seems highly unlikely the code doesn't execute for 2 targets for 100ns, as it was executing for 1ns for 2 targets in all of the runs except this last one up until now.
pinebit
approved these changes
May 8, 2024
KaloyanTanev
force-pushed
the
kalo/charon-test-timeout-of-timeout-tests
branch
from
e68cabc
to
cb19eca
Compare
|
gsora
approved these changes
May 8, 2024
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes timeout is so little that the test doesn't even reach the second instance, as observed in the pipeline here.
category: bug
ticket: none