Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/compose: fixed smoke dkg test #2965

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Mar 14, 2024

SmokeTest/dkg was running by default with Teku VC, which caused a weird (yet unknown) error and the test to fail.
I verified all main commits for the past month trying to find where this was introduced and found that all the commits are failing reliably. I suspect this has something to do with docker engine update (I also updated mine locally and therefore could 100% reproduce the issue).
Even though we still don't know what was wrong with Teku in that specific test, in order to make our builds passing compose tests, I enabled Mock VC for this test, similar to what we do for other DKG tests in the same suite.

category: test
ticket: #2964

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.12%. Comparing base (66b41d7) to head (0419c31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2965      +/-   ##
==========================================
+ Coverage   54.09%   54.12%   +0.03%     
==========================================
  Files         194      194              
  Lines       27402    27396       -6     
==========================================
+ Hits        14822    14827       +5     
+ Misses      10826    10816      -10     
+ Partials     1754     1753       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 14, 2024
@obol-bulldozer obol-bulldozer bot merged commit f8836b8 into main Mar 14, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/smoke-test-dkg-fix branch March 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants