Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/obolapi: add exit endpoints #2926

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Feb 28, 2024

Add partial exit endpoints handlers to Charon's Obol API client package.

Added unit tests and a mock server.

This code was taken and adapted from lido-dv-exit: once this PR gets merged, we'll remove it from there.

category: feature
ticket: #2848

Add partial exit endpoints handlers to Charon's Obol API client package.

Added unit tests and a mock server.

This code was taken and adapted from lido-dv-exit: once this PR gets merged, we'll remove it from there.
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 57.28477% with 129 lines in your changes are missing coverage. Please review.

Project coverage is 53.65%. Comparing base (314d11f) to head (833b29d).

❗ Current head 833b29d differs from pull request most recent head d4ebc8d. Consider uploading reports for the commit d4ebc8d to get more accurate results

Files Patch % Lines
app/obolapi/exit.go 57.79% 44 Missing and 21 partials ⚠️
app/obolapi/exit_model.go 56.75% 44 Missing and 20 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2926      +/-   ##
==========================================
- Coverage   53.65%   53.65%   -0.01%     
==========================================
  Files         200      202       +2     
  Lines       28229    28531     +302     
==========================================
+ Hits        15146    15307     +161     
- Misses      11214    11311      +97     
- Partials     1869     1913      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 29, 2024
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
14.3% Duplication on New Code

See analysis details on SonarCloud

@obol-bulldozer obol-bulldozer bot merged commit a4f9714 into main Feb 29, 2024
11 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/obolapi-exit-endpoints branch February 29, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants