core/validatorapi: return 404 for propose block v3 #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
==========================================
+ Coverage 53.39% 53.48% +0.09%
==========================================
Files 200 200
Lines 28059 28071 +12
==========================================
+ Hits 14982 15014 +32
+ Misses 11211 11191 -20
Partials 1866 1866 ☔ View full report in Codecov by Sentry. |
xenowits
approved these changes
Feb 8, 2024
|
Should we merge #2866 first? |
pinebit
approved these changes
Feb 8, 2024
|
@gsora yeah sure let's merge your PR first, I'll rebase mine after that. |
|
@dB2510 merged! |
dB2510
force-pushed
the
dhruv/v3notsupported
branch
from
e73989d
to
9bbc562
Compare
|
dB2510
added
the
merge when ready
gsora
pushed a commit
that referenced
this pull request
Feb 8, 2024
Returns 404 with message `endpoint not supported` for produce block v3 endpoint to signal VC it is not supported by charon yet. Otherwise charon will proxy this request to beacon node. category: feature ticket: #2749
gsora
pushed a commit
that referenced
this pull request
Feb 8, 2024
Returns 404 with message `endpoint not supported` for produce block v3 endpoint to signal VC it is not supported by charon yet. Otherwise charon will proxy this request to beacon node. category: feature ticket: #2749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns 404 with message
endpoint not supportedfor produce block v3 endpoint to signal VC it is not supported by charon yet. Otherwise charon will proxy this request to beacon node.category: feature
ticket: #2749