cmd/combine: support testnet config #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `--testnet-*` flags to `combine` command. Users must specify custom network name, chain ID genesis timestamp and fork version as hex string to allow for a custom testnet configuration to work.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
+ Coverage 53.45% 53.52% +0.06%
==========================================
Files 200 200
Lines 28035 28058 +23
==========================================
+ Hits 14987 15018 +31
+ Misses 11185 11177 -8
Partials 1863 1863 ☔ View full report in Codecov by Sentry. |
xenowits
reviewed
Feb 5, 2024
xenowits
approved these changes
Feb 5, 2024
dB2510
approved these changes
Feb 5, 2024
|
@gsora we have merge conflicts in this PR. |
|
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--testnet-*flags tocombinecommand.Users must specify custom network name, chain ID genesis timestamp and fork version as hex string to allow for a custom testnet configuration to work.
category: bug
ticket: #2838
Closes #2838.