-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testutil/promrated: update promrated querying #2844
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2844 +/- ##
==========================================
+ Coverage 53.46% 53.50% +0.04%
==========================================
Files 200 200
Lines 28037 28011 -26
==========================================
- Hits 14989 14987 -2
+ Misses 11187 11166 -21
+ Partials 1861 1858 -3 ☔ View full report in Codecov by Sentry. |
Pay attention to linter issues:
You can run |
pre commit passed locally 😞 , think it should be fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the copy-paste error
flags.StringSliceVar(&config.Networks, "node-operators", nil, "Comma separated list of one or node operators to monitor.")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's get at least one more approval from Protocol.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Promrated is needed to fulfill a slightly different purpose these days, refactoring to reflect that and adding a needed endpoint.
category: refactor
ticket: #2843