Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: set -a when building with flags #2274

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jun 5, 2023

Also use -a flag to force rebuild when setting -ldflags when overriding tagged versions.

Since -ldflags=-X path/to/package.Var=foo contains a space inside the value, the only way I could get this to work is to provide it via an additional GO_BUILD_FLAG_2 variable. The other option would be wrangling arrays and splitting using something like IFS=' ' read -ra BUILD_ARGS <<< "$OPTIONAL_BUILD_ARGS" but I feel this is more verbose but simpler to understand.

category: misc
ticket: #2270

@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Jun 5, 2023
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (ef9266a) 53.83% compared to head (1d78b4f) 53.74%.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-v0.16    #2274      +/-   ##
==============================================
- Coverage       53.83%   53.74%   -0.10%     
==============================================
  Files             188      188              
  Lines           25536    25536              
==============================================
- Hits            13747    13724      -23     
- Misses          10101    10128      +27     
+ Partials         1688     1684       -4     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@obol-bulldozer obol-bulldozer bot merged commit 0c4c5d6 into main-v0.16 Jun 5, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/printbflags branch June 5, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants