github: set -a when building with flags #2274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use
-a
flag to force rebuild when setting-ldflags
when overriding tagged versions.Since
-ldflags=-X path/to/package.Var=foo
contains a space inside the value, the only way I could get this to work is to provide it via an additionalGO_BUILD_FLAG_2
variable. The other option would be wrangling arrays and splitting using something likeIFS=' ' read -ra BUILD_ARGS <<< "$OPTIONAL_BUILD_ARGS"
but I feel this is more verbose but simpler to understand.category: misc
ticket: #2270