dkg: lock hash k1 signature in lock file #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures all node operators individually sign the agreed lock hash with their K1 private keys, and stores the resulting signature in the lock file itself.
corverroos
reviewed
May 23, 2023
| @@ -172,6 +177,29 @@ func (l Lock) VerifySignatures() error { | |||
| return errors.Wrap(err, "verify lock signature aggregate") | |||
| } | |||
|
|
|||
| if len(l.NodeSignatures) != 0 { | |||
There was a problem hiding this comment.
please move this to Lock.VerifySignatures remove implicit verification from marshalling, only do explicit verification via VerifySignatures
There was a problem hiding this comment.
not sure I got what you mean, this check is already in Lock.VerifySignature
corverroos
reviewed
May 23, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2224 +/- ##
==========================================
- Coverage 53.79% 53.77% -0.02%
==========================================
Files 187 188 +1
Lines 25059 25191 +132
==========================================
+ Hits 13480 13547 +67
- Misses 9917 9975 +58
- Partials 1662 1669 +7
☔ View full report in Codecov by Sentry. |
…ly, without middleware handlers Instead of initializing a bcast.BroadcastFunc with bcast.New, return a bcast.Component on which callers can register handlers after initialization.
corverroos
reviewed
May 23, 2023
corverroos
approved these changes
May 24, 2023
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures all node operators individually sign the agreed lock hash with their K1 private keys, and stores the resulting signature in the lock file itself.
category: feature
ticket: #2204