cluster/state: legacy lock json and transform #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2182 +/- ##
==========================================
- Coverage 53.58% 53.45% -0.13%
==========================================
Files 174 179 +5
Lines 23073 23422 +349
==========================================
+ Hits 12363 12520 +157
- Misses 9239 9396 +157
- Partials 1471 1506 +35
☔ View full report in Codecov by Sentry. |
xenowits
reviewed
May 12, 2023
| Name string | ||
| Threshold int | ||
| DKGAlgorithm string | ||
| ForkVersion []byte |
There was a problem hiding this comment.
nit: why not use Network string?
There was a problem hiding this comment.
I'm using the same cluster.Definition types
xenowits
approved these changes
May 12, 2023
dB2510
approved these changes
May 12, 2023
cluster/state/mutationlegacylock.go
Outdated
| @@ -85,7 +89,36 @@ func transformLegacyLock(_ Cluster, signed SignedMutation) (Cluster, error) { | |||
| return Cluster{}, errors.Wrap(err, "verify legacy lock") | |||
| } | |||
|
|
|||
| // TODO(corver): Implement legacy lock transform. | |||
| lock := signed.Mutation.Data.(lockWrapper) | |||
There was a problem hiding this comment.
nit: check comma ok please, same as line 64-66 in the same file
There was a problem hiding this comment.
verify function already checks that type is correct, I'll add a comment
Co-authored-by: Dhruv Bodani <[email protected]>
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add legacy lock serialisation and transform logic.
category: feature
ticket: #1886