cluster/state: implement legacy lock mutation #2175
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
==========================================
+ Coverage 53.45% 53.54% +0.09%
==========================================
Files 174 174
Lines 22987 23080 +93
==========================================
+ Hits 12287 12359 +72
- Misses 9232 9248 +16
- Partials 1468 1473 +5 ☔ View full report in Codecov by Sentry. |
cluster/state/helpers.go
Outdated
| defer ssz.DefaultHasherPool.Put(hw) | ||
|
|
||
| if err := hasher.HashTreeRootWith(hw); err != nil { | ||
| return [32]byte{}, err |
cluster/state/mutation.go
Outdated
| ) | ||
|
|
||
| var mutationDefs = map[MutationType]struct { | ||
| DataType any |
There was a problem hiding this comment.
thanks, removed this field, not needed I think.
| return resp, nil | ||
| } | ||
|
|
||
| // verifyEmptySig verifies that the signed mutation isn't signed. |
There was a problem hiding this comment.
nit
| // verifyEmptySig verifies that the signed mutation isn't signed. | |
| // verifyEmptySig returns an error if the signed mutation isn't signed. |
There was a problem hiding this comment.
your change flips the logic which isn't correct.
| // Parent is the hash of the parent mutation. | ||
| Parent [32]byte `ssz:"Bytes32"` | ||
| // Type is the type of mutation. | ||
| Type MutationType `ssz:"ByteList[64]"` // TODO(corver): Make this a numbered enum maybe (instead of a string)?. |
There was a problem hiding this comment.
yeah, numbered enum makes sense. What benefit does having string MutationType provides?..
There was a problem hiding this comment.
string makes it human readable in the json, otherwise it will be a number in the json which means when a human looks at it, they will not know what mutation type they are looking at.
corverroos
added
the
merge when ready
Implement the first skeleton and structure of the
LegacyLockmutation. This is heavy based on previous PoC.This is the first of a series of PRs, next PRs will add tests and more logic.
category: feature
ticket: #1886