createdkg: validate inputs #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenowits
commented
Apr 26, 2023
| func isMainNetwork(network string) bool { | ||
| // validateConfig returns an error if any of the provided config parameter is invalid. | ||
| func validateConfig(threshold, numOperators int, network string) error { | ||
| if threshold > numOperators { |
xenowits
commented
Apr 26, 2023
| return errors.Wrap(err, "invalid withdrawal address", z.Str("addr", addr)) | ||
| } else if checksumAddr != addr { |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
+ Coverage 53.37% 53.41% +0.03%
==========================================
Files 174 174
Lines 22799 22815 +16
==========================================
+ Hits 12170 12186 +16
- Misses 9167 9168 +1
+ Partials 1462 1461 -1
☔ View full report in Codecov by Sentry. |
xenowits
commented
Apr 27, 2023
| @@ -36,8 +36,9 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| // zeroAddress is not owned by any user, is often associated with token burn & mint/genesis events and used as a generic null address. | |||
corverroos
approved these changes
Apr 27, 2023
xenowits
added
sigp audit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks to validate inputs for
create dkgcommand.Fixes OBOL-19 and OBOL-20 of sigp audit.
category: feature
ticket: #2093