Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/consensus: double lead time alpha feature #2096

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Apr 13, 2023

Introduces alpha feature QBFTDoubleLeadTimer that attempts to address sporadic consensus timeouts on block proposals by doubling round timers on receive justified pre-prepare for the current round.

category: feature
ticket: #2092

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 98.41% and project coverage change: -0.17 ⚠️

Comparison is base (8af7bdc) 53.76% compared to head (37b2c62) 53.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2096      +/-   ##
==========================================
- Coverage   53.76%   53.59%   -0.17%     
==========================================
  Files         171      172       +1     
  Lines       22252    22282      +30     
==========================================
- Hits        11963    11943      -20     
- Misses       8841     8890      +49     
- Partials     1448     1449       +1     
Impacted Files Coverage Δ
app/app.go 7.88% <0.00%> (ø)
app/featureset/featureset.go 100.00% <ø> (ø)
core/consensus/component.go 63.68% <100.00%> (ø)
core/consensus/roundtimer.go 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/consensus/roundtimer.go Outdated Show resolved Hide resolved
core/consensus/roundtimer.go Outdated Show resolved Hide resolved
@corverroos corverroos changed the title core/consensus: add double on timeout alpha feature core/consensus: no reset timer alpha feature Apr 13, 2023
@corverroos corverroos changed the title core/consensus: no reset timer alpha feature core/consensus: double lead time alpha feature Apr 17, 2023
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 17, 2023
@obol-bulldozer obol-bulldozer bot merged commit 889cba4 into main Apr 17, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/qbftdouble branch April 17, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants