Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beaconmock: remove backoff dependency #2089

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

xenowits
Copy link
Contributor

Remove gopkg.in/cenkalti/backoff.v1 direct dependency by removing its usage in headproducer_internal_test.go. Though it is still present as an indirect dependency since sse/v2 uses it.

category: refactor
ticket: #2083

@xenowits xenowits self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.18 ⚠️

Comparison is base (0dd410d) 53.63% compared to head (645f2ad) 53.45%.

❗ Current head 645f2ad differs from pull request most recent head da81bec. Consider uploading reports for the commit da81bec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
- Coverage   53.63%   53.45%   -0.18%     
==========================================
  Files         174      174              
  Lines       22671    22671              
==========================================
- Hits        12159    12119      -40     
- Misses       9004     9044      +40     
  Partials     1508     1508              

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits added sigp audit Issues identified by sigma prime audit merge when ready Indicates bulldozer bot may merge when all checks pass labels Apr 12, 2023
@obol-bulldozer obol-bulldozer bot merged commit e755677 into main Apr 12, 2023
@obol-bulldozer obol-bulldozer bot deleted the xenowits/rm-cenkalti branch April 12, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass sigp audit Issues identified by sigma prime audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants