sigagg: validate threshold unique partial signatures #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2061 +/- ##
=======================================
Coverage 53.44% 53.45%
=======================================
Files 174 174
Lines 22558 22561 +3
=======================================
+ Hits 12057 12060 +3
- Misses 8995 8996 +1
+ Partials 1506 1505 -1
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
corverroos
approved these changes
Apr 7, 2023
xenowits
added
the
merge when ready
LukeHackett12
pushed a commit
that referenced
this pull request
Apr 11, 2023
Adds check to `sigAgg` so that it returns an error when `Aggregate()` is called with less than `threshold` number of unique partial signatures. category: bug ticket: #2053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds check to
sigAggso that it returns an error whenAggregate()is called with less thanthresholdnumber of unique partial signatures.category: bug
ticket: #2053