dkg: refactor to reliable broadcast #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Mar 17, 2023
corverroos
commented
Mar 17, 2023
| ) (map[uint32]*frost.Round1Bcast, map[uint32]*sharing.ShamirShare) { | ||
| castMap := make(map[uint32]*frost.Round1Bcast) | ||
| for key, cast := range castR1 { | ||
| if key.ValIdx != vIdx { | ||
| continue | ||
| } | ||
| if key.TargetID != targetID { |
There was a problem hiding this comment.
validation moved to when first received over the wire
gsora
reviewed
Mar 17, 2023
Co-authored-by: Gianguido Sorà <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1896 +/- ##
=======================================
Coverage 55.68% 55.69%
=======================================
Files 172 172
Lines 22073 22073
=======================================
+ Hits 12292 12294 +2
+ Misses 8207 8205 -2
Partials 1574 1574
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gsora
approved these changes
Mar 17, 2023
dB2510
approved these changes
Mar 17, 2023
| @@ -20,7 +20,7 @@ func TestFrostDKG(t *testing.T) { | |||
|
|
|||
| const ( | |||
| nodes = 3 | |||
| vals = 2 | |||
There was a problem hiding this comment.
debugging, thanks will revert
corverroos
added
the
merge when ready
corverroos
removed
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor DKG to use reliable broadcast instead of p2p broadcast.
category: feature
ticket: #1889