p2p: fix recursive context leak #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dB2510
approved these changes
Feb 21, 2023
Codecov ReportBase: 55.20% // Head: 54.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
- Coverage 55.20% 54.99% -0.21%
==========================================
Files 169 169
Lines 22140 22137 -3
==========================================
- Hits 12222 12174 -48
- Misses 8355 8396 +41
- Partials 1563 1567 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
commented
Feb 21, 2023
| } | ||
|
|
||
| log.Debug(ctx, "Refreshing relay circuit reservation") | ||
| relayConnGauge.WithLabelValues(name).Set(0) |
There was a problem hiding this comment.
clear gauge, this fixes issue of "previous relay getting stuck" in the metrics.
corverroos
commented
Feb 21, 2023
| relayPeer, ok := relay.Peer() | ||
| if !ok { | ||
| time.Sleep(time.Second * 10) // Constant 10s backoff ok for mutexed lookups | ||
| continue | ||
| } | ||
|
|
||
| name := PeerName(relayPeer.ID) | ||
| ctx = log.WithCtx(ctx, z.Str("relay_peer", name)) |
There was a problem hiding this comment.
recursive wrapping cause the leak
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes recursive context wrapping that caused a memory leak.
category: bug
ticket: none