app: refactor VC readyz checks #1761
Conversation
Codecov ReportBase: 55.08% // Head: 55.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
- Coverage 55.08% 55.03% -0.05%
==========================================
Files 164 164
Lines 21387 21392 +5
==========================================
- Hits 11780 11774 -6
- Misses 8067 8075 +8
- Partials 1540 1543 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| case <-epochTicker.Chan(): | ||
| // Copy current to previous and clear current. | ||
| previous, current = current, newCurrent() | ||
| prevPKs, currPKs = currPKs, make(map[core.PubKey]bool) |
There was a problem hiding this comment.
| prevPKs, currPKs = currPKs, make(map[core.PubKey]bool) | |
| prevPubkeys, currPubkeys = currPubkeys, make(map[core.PubKey]bool) |
There was a problem hiding this comment.
same for other places as well
There was a problem hiding this comment.
I feel PKs is a clear enough
| } | ||
|
|
||
| return current | ||
| currVAPICount := 0 |
There was a problem hiding this comment.
nit: this vapi count can be boolean too
There was a problem hiding this comment.
sure, but a count is more representative
corverroos
added
the
merge when ready
Changes VC readyz statuses:
vc not connectedindicates no vapi callsvc missing validatorsindicates some or all validators not configured in VCcategory: refactor
ticket: #1612