Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/promrated: only report status code #1746

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

LukeHackett12
Copy link
Contributor

@LukeHackett12 LukeHackett12 commented Jan 31, 2023

remove the endpoint from error metric

category: bug
ticket: #1738

Copy link
Contributor

@aly-obol aly-obol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 54.77% // Head: 54.59% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (a71dc7e) compared to base (3360ba8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
- Coverage   54.77%   54.59%   -0.19%     
==========================================
  Files         162      162              
  Lines       20825    20825              
==========================================
- Hits        11407    11369      -38     
- Misses       7891     7932      +41     
+ Partials     1527     1524       -3     
Impacted Files Coverage Δ
testutil/promrated/rated.go 54.66% <0.00%> (ø)
core/qbft/qbft.go 73.73% <0.00%> (-8.62%) ⬇️
app/vmock.go 75.64% <0.00%> (+1.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LukeHackett12 LukeHackett12 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 31, 2023
@obol-bulldozer obol-bulldozer bot merged commit ec8f9be into main Jan 31, 2023
@obol-bulldozer obol-bulldozer bot deleted the luke/promrated-fix branch January 31, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants