core/dutydb: delete cancelled queries #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.08% // Head: 53.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
- Coverage 54.08% 53.93% -0.16%
==========================================
Files 157 157
Lines 19880 19916 +36
==========================================
- Hits 10752 10741 -11
- Misses 7674 7721 +47
Partials 1454 1454
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
approved these changes
Jan 6, 2023
corverroos
added
the
merge when ready
xenowits
reviewed
Jan 6, 2023
Comment on lines
+745
to
+746
| case <-cancel: | ||
| return true |
There was a problem hiding this comment.
case _, ok := <-cancel:
return !okok is false if there are no more values to receive and the channel is closed. https://go.dev/tour/concurrency/4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete expired dutydb queries since they may never be resolved which causes a memory leak.
category: bug
ticket: #1583