Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/monitoringapi: detect all validators queried by VC #1566

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Dec 15, 2022

Configures monitoringapi to detect all validators queried by VC.

category: feature
ticket: #1501

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 54.15% // Head: 54.17% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (3958e66) compared to base (592de00).
Patch coverage: 76.92% of modified lines in pull request are covered.

❗ Current head 3958e66 differs from pull request most recent head fd99ea5. Consider uploading reports for the commit fd99ea5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1566      +/-   ##
==========================================
+ Coverage   54.15%   54.17%   +0.02%     
==========================================
  Files         153      156       +3     
  Lines       19430    19626     +196     
==========================================
+ Hits        10522    10633     +111     
- Misses       7483     7552      +69     
- Partials     1425     1441      +16     
Impacted Files Coverage Δ
app/metrics.go 100.00% <ø> (ø)
core/validatorapi/validatorapi.go 57.95% <0.00%> (-0.25%) ⬇️
app/app.go 63.62% <62.50%> (-0.98%) ⬇️
app/monitoringapi.go 81.30% <100.00%> (+4.30%) ⬆️
cmd/bootnode/p2p.go 38.06% <0.00%> (-3.85%) ⬇️
core/priority/prioritiser.go 60.48% <0.00%> (-1.21%) ⬇️
core/consensus/component.go 61.90% <0.00%> (-0.97%) ⬇️
dkg/sync/server.go 63.85% <0.00%> (-0.78%) ⬇️
cmd/createcluster.go 46.80% <0.00%> (-0.44%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/metrics.go Outdated Show resolved Hide resolved
app/monitoringapi.go Outdated Show resolved Hide resolved
app/monitoringapi.go Outdated Show resolved Hide resolved
app/monitoringapi.go Show resolved Hide resolved
app/monitoringapi_internal_test.go Outdated Show resolved Hide resolved
app/monitoringapi_internal_test.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
@dB2510 dB2510 linked an issue Dec 15, 2022 that may be closed by this pull request
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Dec 15, 2022
@obol-bulldozer obol-bulldozer bot merged commit 708c345 into main Dec 15, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/detectvc branch December 15, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect all validators queried by VC
2 participants