testutil/promrated: add initial basic looping and read in config #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeHackett12
changed the title
Codecov ReportBase: 54.32% // Head: 54.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
+ Coverage 54.32% 54.39% +0.06%
==========================================
Files 153 153
Lines 19426 19426
==========================================
+ Hits 10554 10567 +13
+ Misses 7447 7435 -12
+ Partials 1425 1424 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
suggested changes
Dec 13, 2022
LukeHackett12
force-pushed
the
luke/promrated-basic-cfg
branch
from
12701da
to
0d189e1
Compare
corverroos
approved these changes
Dec 13, 2022
| Long: `Starts a promrated server that polls rated and makes metrics available to prometheus`, | ||
| Args: cobra.NoArgs, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| return runFunc(cmd.Context(), config) |
There was a problem hiding this comment.
if you want to support ENV vars and config files (in addition to --flags) you'll need to export and call cmd.initializeConfig, but adding that later when actually required is best.
LukeHackett12
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of #1540. Per corvers suggestion taking incremental steps instead of a large code dump. This starts by reading the necessary config values, then runs on a loop every 10 mins with some logging. After this I will expose some metrics to prometheus then start some of the more complex logic for fetching clusters and polling rated.
ticket: #1540
category: misc