Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: wire synthetic block proposals #1499

Merged
merged 2 commits into from
Dec 6, 2022
Merged

app: wire synthetic block proposals #1499

merged 2 commits into from
Dec 6, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Dec 1, 2022

Wire synthetic block proposals via the config flag --synthetic-block-proposals. Also enable this by default in compose, it replaces beaconmock scheduled deterministic duties.

category: feature
ticket: #1486

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 53.96% // Head: 54.27% // Increases project coverage by +0.31% 🎉

Coverage data is based on head (883de36) compared to base (2412df7).
Patch coverage: 52.43% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
+ Coverage   53.96%   54.27%   +0.31%     
==========================================
  Files         149      149              
  Lines       19019    19022       +3     
==========================================
+ Hits        10263    10324      +61     
+ Misses       7350     7293      -57     
+ Partials     1406     1405       -1     
Impacted Files Coverage Δ
app/eth2wrap/synthproposer.go 64.45% <38.18%> (-13.02%) ⬇️
app/app.go 64.27% <58.33%> (+0.67%) ⬆️
app/eth2wrap/eth2wrap.go 61.53% <100.00%> (+1.39%) ⬆️
app/eth2wrap/httpwrap.go 25.45% <100.00%> (-8.63%) ⬇️
cmd/run.go 93.93% <100.00%> (+0.06%) ⬆️
testutil/compose/lock.go 75.00% <100.00%> (+0.21%) ⬆️
app/vmock.go 74.61% <0.00%> (+0.51%) ⬆️
app/eth2wrap/eth2wrap_gen.go 21.06% <0.00%> (+2.08%) ⬆️
core/qbft/qbft.go 82.04% <0.00%> (+9.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Dec 6, 2022
@obol-bulldozer obol-bulldozer bot merged commit cb9a968 into main Dec 6, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/wiresynth branch December 6, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants