Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: integrate DutySyncContribution #1388

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Nov 6, 2022

Integrate DutySyncContribution into core workflow. Also, test on simnet.

category: feature
ticket: #1268

@xenowits xenowits self-assigned this Nov 6, 2022
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 53.50% // Head: 53.35% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (3dfee37) compared to base (c7d1bc8).
Patch coverage: 3.12% of modified lines in pull request are covered.

❗ Current head 3dfee37 differs from pull request most recent head f7191ab. Consider uploading reports for the commit f7191ab to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
- Coverage   53.50%   53.35%   -0.15%     
==========================================
  Files         145      145              
  Lines       18041    18119      +78     
==========================================
+ Hits         9652     9667      +15     
- Misses       7060     7126      +66     
+ Partials     1329     1326       -3     
Impacted Files Coverage Δ
app/eth2wrap/httpwrap.go 0.00% <0.00%> (ø)
core/interfaces.go 0.00% <0.00%> (ø)
core/signeddata.go 44.12% <ø> (ø)
testutil/beaconmock/attestation.go 85.71% <ø> (ø)
testutil/beaconmock/beaconmock.go 49.15% <0.00%> (ø)
testutil/beaconmock/options.go 34.41% <0.00%> (-1.36%) ⬇️
testutil/validatormock/attest.go 58.49% <0.00%> (ø)
testutil/validatormock/synccomm.go 0.00% <0.00%> (ø)
app/vmock.go 79.25% <66.66%> (+3.31%) ⬆️
core/validatorapi/validatorapi.go 58.32% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

testutil/validatormock/attest.go Outdated Show resolved Hide resolved
testutil/validatormock/synccomm.go Outdated Show resolved Hide resolved
testutil/validatormock/synccomm.go Outdated Show resolved Hide resolved
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 7, 2022
@obol-bulldozer obol-bulldozer bot merged commit 3405b93 into main Nov 7, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/integrate-synccomm branch November 7, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants