app/eth2wrap: fix cancelled context race #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Nov 2, 2022
| zero O | ||
| nokResp forkjoin.Result[Client, O] | ||
| hasNokResp bool | ||
| zero O | ||
| ) | ||
| for res := range join() { |
There was a problem hiding this comment.
when the calling context is already/immediately closed, then forkjoin doesn't return any results.
corverroos
commented
Nov 2, 2022
| } | ||
| } | ||
|
|
||
| if ctx.Err() != nil { | ||
| return zero, ctx.Err() | ||
| } else if !hasNokResp { |
There was a problem hiding this comment.
this is just a sanity check and should never happen
Codecov ReportBase: 54.19% // Head: 54.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
==========================================
+ Coverage 54.19% 54.26% +0.07%
==========================================
Files 144 144
Lines 17750 17757 +7
==========================================
+ Hits 9619 9636 +17
+ Misses 6809 6796 -13
- Partials 1322 1325 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
approved these changes
Nov 2, 2022
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race in
eth2wrapforkjoin code when context is cancelled before any results are returned. This resulted in<zero>,nilbeing returned which resulted in unexpected behaviour, including "divide by zero".category: bug
ticket: #1326