Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/parsigdb: use message root for consistency check #1350

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Oct 25, 2022

Use message root for partial signed data consistency check in parsigdb. Also do the same in tracker.

category: refactor
ticket: #1347

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 53.52% // Head: 53.55% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (1adbc2c) compared to base (c1981a5).
Patch coverage: 68.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
+ Coverage   53.52%   53.55%   +0.03%     
==========================================
  Files         142      142              
  Lines       17137    17138       +1     
==========================================
+ Hits         9172     9179       +7     
+ Misses       6689     6686       -3     
+ Partials     1276     1273       -3     
Impacted Files Coverage Δ
core/parsigdb/memory.go 10.34% <45.45%> (-5.92%) ⬇️
core/tracker/tracker.go 75.00% <80.95%> (+1.42%) ⬆️
core/leadercast/transport.go 75.14% <0.00%> (-1.19%) ⬇️
core/scheduler/scheduler.go 72.94% <0.00%> (-0.54%) ⬇️
app/vmock.go 77.00% <0.00%> (+1.60%) ⬆️
app/peerinfo/peerinfo.go 57.93% <0.00%> (+3.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 26, 2022
@obol-bulldozer obol-bulldozer bot merged commit 19dd5b7 into main Oct 26, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/parsigdbroot branch October 26, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants