app/log: add loki client #1337
app/log: add loki client #1337
Conversation
corverroos
added
documentation
Codecov ReportBase: 53.37% // Head: 53.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1337 +/- ##
==========================================
+ Coverage 53.37% 53.44% +0.07%
==========================================
Files 145 147 +2
Lines 18193 18316 +123
==========================================
+ Hits 9710 9789 +79
- Misses 7145 7178 +33
- Partials 1338 1349 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
force-pushed
the
corver/promtail
branch
from
568a0a1
to
3e58dc6
Compare
corverroos
removed
the
do not merge
| Line: line, | ||
| }) | ||
| if batch.Size() > c.batchMax { | ||
| batch = newBatch(c.service) // Just silently drop, there should have been multiple error logs below. |
There was a problem hiding this comment.
why dropping complete batch?
There was a problem hiding this comment.
As per package godoc:
// It is best-effort, meaning it doesn't provide delivery guarantees, it will drop logs if
// loki isn't accessible. It is meant to be used in local dev environments or where log
// delivery isn't critical.
There was a problem hiding this comment.
If you need guarantees, then use proper 12factor app patterns and official tools.
app/log/loki/client.go
Outdated
| case <-ticker.C: | ||
| // Do not send if the batch is too young | ||
| if batch.Age() < c.batchWait { | ||
| break |
There was a problem hiding this comment.
it should be continue rather than break?
corverroos
added
the
merge when ready
Add simple loki client to directly sending logs to loki instead of jumping through docker-compose hoops. Still needs to be integrated.
category: feature
ticket: #1406