Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: fix missing error from SendReceive #1304

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Oct 18, 2022

Fixes issue with PeerInfo protocol reporting zero values like SentAt. This was due to missing returned error from p2p.Sender.SendReceive.

category: bug
ticket: #1295

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 53.63% // Head: 53.62% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (05b16c8) compared to base (428fa8a).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
- Coverage   53.63%   53.62%   -0.02%     
==========================================
  Files         140      140              
  Lines       16869    16869              
==========================================
- Hits         9048     9046       -2     
- Misses       6545     6546       +1     
- Partials     1276     1277       +1     
Impacted Files Coverage Δ
p2p/sender.go 43.95% <0.00%> (ø)
app/peerinfo/peerinfo.go 54.48% <100.00%> (ø)
core/priority/prioritiser.go 63.73% <0.00%> (-1.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits
Copy link
Contributor

isn't this PR associated with #1295 ?

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 18, 2022
@obol-bulldozer obol-bulldozer bot merged commit 4ebd38e into main Oct 18, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/p2psenderr branch October 18, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants