version: log charon version info on startup #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.39% // Head: 53.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 53.39% 53.67% +0.28%
==========================================
Files 139 139
Lines 16354 16356 +2
==========================================
+ Hits 8732 8779 +47
+ Misses 6367 6322 -45
Partials 1255 1255
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
commented
Oct 12, 2022
app/version/version.go
Outdated
| @@ -40,3 +46,13 @@ func GitCommit() (hash string, timestamp string) { | |||
|
|
|||
| return hash, timestamp | |||
| } | |||
|
|
|||
| // LogCharonInfo logs charon version information along-with the provided message. | |||
| func LogCharonInfo(ctx context.Context, msg string) { | |||
There was a problem hiding this comment.
i couldn't up with a better name, so suggestions welcome
There was a problem hiding this comment.
"Charon" is superfluous, since everything in this codebase is charon...
corverroos
approved these changes
Oct 12, 2022
app/version/version.go
Outdated
| @@ -40,3 +46,13 @@ func GitCommit() (hash string, timestamp string) { | |||
|
|
|||
| return hash, timestamp | |||
| } | |||
|
|
|||
| // LogCharonInfo logs charon version information along-with the provided message. | |||
| func LogCharonInfo(ctx context.Context, msg string) { | |||
app/version/version.go
Outdated
| @@ -40,3 +46,13 @@ func GitCommit() (hash string, timestamp string) { | |||
|
|
|||
| return hash, timestamp | |||
| } | |||
|
|
|||
| // LogCharonInfo logs charon version information along-with the provided message. | |||
| func LogCharonInfo(ctx context.Context, msg string) { | |||
There was a problem hiding this comment.
"Charon" is superfluous, since everything in this codebase is charon...
xenowits
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a common function to log charon version information on startup.
category: feature
ticket: #1194