core/priority: refactor priority protocol #1271
Conversation
| for _, topic := range msg.Topics { | ||
| if dedupTopics(msg.PeerId) { |
Codecov ReportBase: 53.75% // Head: 53.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
==========================================
- Coverage 53.75% 53.74% -0.01%
==========================================
Files 139 139
Lines 16365 16446 +81
==========================================
+ Hits 8797 8839 +42
- Misses 6312 6345 +33
- Partials 1256 1262 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| // Calculate overall score for all priorities in the topic | ||
| // which effectively orders by count then by overall priority. | ||
| var ( | ||
| scores = make(map[string]int) | ||
| allPriorities []string | ||
| scores = make(map[[32]byte]int) |
There was a problem hiding this comment.
can we give [32]byte a type? will make it more readable
There was a problem hiding this comment.
yeah not sure, I actually removed the instanceKey type, reverting to just [32]byte. I think defining types is mostly useful if the scope of the type is very large. In this case, it is pretty small.
core/priority/prioritiser.go
Outdated
| // Priority is one of many grouped by a Topic being prioritised in an Instance. | ||
| type Priority proto.Message | ||
|
|
||
| // instanceKey is the hash of an Instance proto.Message and is used to index instanceData. See hashProto. |
There was a problem hiding this comment.
| // instanceKey is the hash of an Instance proto.Message and is used to index instanceData. See hashProto. | |
| // instanceKey is the hash of an Instance and is used to index instanceData. See hashProto. |
There was a problem hiding this comment.
think the original is fine
corverroos
added
the
merge when ready
Refactors the priority protocol:
anypb.Anyto support arbitrary use-cases.category: refactor
ticket: #1257