Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add spec for latest EIP712 signatures #1234

Merged
merged 6 commits into from
Oct 6, 2022
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Oct 6, 2022

Adds spec for latest EIP712 signature changes. Also refactors the code structure a bit.

category: docs
ticket: #1203

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 53.39% // Head: 53.38% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (df9ddbc) compared to base (54d0553).
Patch coverage: 77.04% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
- Coverage   53.39%   53.38%   -0.01%     
==========================================
  Files         138      139       +1     
  Lines       16132    16127       -5     
==========================================
- Hits         8614     8610       -4     
- Misses       6268     6269       +1     
+ Partials     1250     1248       -2     
Impacted Files Coverage Δ
cluster/eip712sigs.go 75.00% <75.00%> (ø)
cluster/test_cluster.go 82.45% <75.00%> (+3.94%) ⬆️
cluster/definition.go 60.07% <100.00%> (+0.96%) ⬆️
cluster/helpers.go 59.43% <100.00%> (-4.46%) ⬇️
dkg/transport.go 53.70% <0.00%> (-12.97%) ⬇️
core/priority/prioritiser.go 60.52% <0.00%> (-1.32%) ⬇️
core/scheduler/scheduler.go 73.13% <0.00%> (-0.54%) ⬇️
app/vmock.go 73.85% <0.00%> (+1.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 6, 2022
@obol-bulldozer obol-bulldozer bot merged commit 772f768 into main Oct 6, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/sigspec branch October 6, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants